Use unique Android namespaces #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users building Android apps with version 9.0+ of the Android Gradle plugin, there are issues because the
:commonand:coreprojects use the same Android namespace. This fixes that by making them unique.Ideally, we should be able to adopt AGP version 9.0 in our build to verify these changes. I've started working on that, but ran into issues with some other plugins like
keepernot being compatible. Using AGP version 9.x also requires additional build changes and causes sync issues with the latest Android Studio version for me. So we may have to wait a bit before migrating.For now, I've "tested" this by searching for
namespace =in the project and verifying the results are unique.This closes #289.