Skip to content

Fix Apple frameworks to contain version numbers #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simolus3 merged 1 commit into from
Dec 17, 2025
Merged

Fix Apple frameworks to contain version numbers #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ development=true
RELEASE_SIGNING_ENABLED=true
# Library config
GROUP=com.powersync
LIBRARY_VERSION=1.10.0
LIBRARY_VERSION=1.10.1
GITHUB_REPO=https://github.com/powersync-ja/powersync-kotlin.git
# POM
POM_URL=https://github.com/powersync-ja/powersync-kotlin/
Expand Down
1 change: 1 addition & 0 deletions internal/PowerSyncKotlin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ plugins {
alias(libs.plugins.kotlinMultiplatform)
alias(libs.plugins.skie)
alias(libs.plugins.kotlinter)
id("com.powersync.plugins.version")
}

kotlin {
Expand Down
5 changes: 5 additions & 0 deletions plugins/sonatype/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ gradlePlugin {
id = "com.powersync.plugins.sonatype"
implementationClass = "com.powersync.plugins.sonatype.SonatypeCentralUploadPlugin"
}

val versionPlugin by plugins.creating {
id = "com.powersync.plugins.version"
implementationClass = "com.powersync.plugins.PowerSyncVersionPlugin"
}
}

// The target release option here is the version of the JVM running the build by default, but Kotlin
Expand Down
11 changes: 11 additions & 0 deletions plugins/sonatype/src/main/kotlin/com/powersync/plugins/PowerSyncVersionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package com.powersync.plugins

import org.gradle.api.Plugin
import org.gradle.api.Project

internal class PowerSyncVersionPlugin: Plugin<Project> {
override fun apply(project: Project) {
project.group = project.property("GROUP") as String
project.version = project.property("LIBRARY_VERSION") as String
}
}
6 changes: 3 additions & 3 deletions ...ns/sonatype/src/main/kotlin/com/powersync/plugins/sonatype/SonatypeCentralUploadPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.powersync.plugins.sonatype

import com.powersync.plugins.PowerSyncVersionPlugin
import org.gradle.api.Plugin
import org.gradle.api.Project
import com.vanniktech.maven.publish.MavenPublishPlugin
Expand All @@ -9,10 +10,9 @@ import com.vanniktech.maven.publish.MavenPublishBaseExtension

internal class SonatypeCentralUploadPlugin : Plugin<Project> {
override fun apply(project: Project) {
project.logger.info("Applying the `gradle-maven-publish` plugin")
project.group = project.property("GROUP") as String
project.version = project.property("LIBRARY_VERSION") as String
project.plugins.apply(PowerSyncVersionPlugin::class.java)

project.logger.info("Applying the `gradle-maven-publish` plugin")
project.plugins.apply(MavenPublishPlugin::class.java)

val extension = project.extensions.create(
Expand Down