Skip to content

Clear retryOps on error #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevensJourney merged 3 commits into from
Dec 8, 2025
Merged

Clear retryOps on error #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65b309c
fix: clear retry ops after failure
stevensJourney Dec 8, 2025
cb67abc
update changeset
stevensJourney Dec 8, 2025
034aa54
delete markdown
stevensJourney Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-pants-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@journeyapps/wa-sqlite': patch
---

Clear retryOps after waiting for ops. This can fix issues on OPFSCoopSyncVFS where is an access handle failed to be obtained once, it could lock the entire connection indefinitely.
7 changes: 5 additions & 2 deletions src/sqlite-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,8 +898,11 @@ export function Factory(Module) {
// Wait for all pending retry operations to complete. This is
// normally empty on the first loop iteration.
if (Module.retryOps.length) {
await Promise.all(Module.retryOps);
Module.retryOps = [];
try {
await Promise.all(Module.retryOps);
} finally {
Module.retryOps = [];
}
}

rc = await f();
Expand Down