Skip to content

[TEST]: Faster mld_ct_abs_i32 #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mkannwischer wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Draft

[TEST]: Faster mld_ct_abs_i32 #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mldsa/src/ct.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,22 @@ __contract__(
* Arguments: int32_t x: Input value
*
**************************************************/
#ifdef CBMC
#pragma CPROVER check push
#pragma CPROVER check disable "unsigned-overflow"
#endif
static MLD_INLINE int32_t mld_ct_abs_i32(int32_t x)
__contract__(
requires(x >= -INT32_MAX)
ensures(return_value == ((x < 0) ? -x : x))
)
{
return mld_ct_sel_int32(-x, x, mld_ct_cmask_neg_i32(x));
uint32_t mask = mld_ct_cmask_neg_i32(x);
return mld_cast_uint32_to_int32((mld_cast_int32_to_uint32(x) ^ mask) - mask);
}
#ifdef CBMC
#pragma CPROVER check pop
#endif

#if !defined(__ASSEMBLER__)
#include <string.h>
Expand Down
2 changes: 1 addition & 1 deletion proofs/cbmc/ct_abs_i32/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ PROOF_SOURCES += $(PROOFDIR)/$(HARNESS_FILE).c
PROJECT_SOURCES += $(SRCDIR)/mldsa/src/ct.c

CHECK_FUNCTION_CONTRACTS=mld_ct_abs_i32
USE_FUNCTION_CONTRACTS=mld_ct_sel_int32 mld_ct_cmask_neg_i32
USE_FUNCTION_CONTRACTS=mld_ct_cmask_neg_i32
APPLY_LOOP_CONTRACTS=on
USE_DYNAMIC_FRAMES=1

Expand Down
Loading