Greatly reduces the usage of Unbounded_String #46
Conversation
… String interface. Cleanup
| ------------------ | ||
| -- Format_Input -- | ||
| ------------------ |
There was a problem hiding this comment.
I've seen a lot of Ada with blocks like this, but I find it incredibly distracting, especially when renaming the subprogram will likely result in needing to modify this comment header as well.
| declare | ||
| US : constant ASU.Unbounded_String := V ( Positive (Index)); | ||
| S : constant String := ASU.To_String (US); | ||
| -- US : constant String := V ( Positive (Index)); |
| New_Min : constant Positive := Positive'Max (A.Minimum, B.Minimum); | ||
| New_Max : constant Positive := Positive'Min (A.Maximum, B.Maximum); | ||
| use Ada.Strings.Unbounded; | ||
| -- use Ada.Strings.Unbounded; |
| end if; | ||
| end loop; | ||
|
|
||
| return To_String (Result); |
There was a problem hiding this comment.
This looks like it results in an additional copy to the stack on every call to this function.
|
This changes 10% of the code base. What is the purpose of this change? Does it result in a measurable performance increase (as seen with Yes, there is a lot of copying between General comments about this project's style:
|
2 participants
No description provided.