Skip to content

Improve accessibility: wrap logo in div not H1 #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Improve accessibility: wrap logo in div not H1 #2844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/sass/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,6 @@ h2.not-column {
text-align: center;
padding: .75em 1em; }

/*h1*/
.site-headline {
color: white;
margin: 0.15em auto 0.2em; }
Expand Down
2 changes: 1 addition & 1 deletion static/sass/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ h2.not-column {
}
}

/*h1*/ .site-headline {
.site-headline {
color: $white;
margin: 0.15em auto 0.2em;

Expand Down
4 changes: 2 additions & 2 deletions templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@
<header class="main-header" role="banner">
<div class="container">

<h1 class="site-headline">
<div class="site-headline">
{% block section-logo %}<a href="/"><img class="python-logo" src="{{ STATIC_URL }}img/python-logo.png" alt="python&trade;"></a>{% endblock %}
</h1>
</div>

<div class="options-bar-container do-not-print">
<a href="https://donate.python.org/" class="donate-button">Donate</a>
Expand Down