Support for GIF images in PDFKit (WIP) #7

DuncanMacWeb · 2019-03-14T19:21:42Z

This supports diegomura/react-pdf#507.

@alexvdev

Outline support by @alexvdev and @blforce Close foliojs#216, close foliojs#13

Fix long-running loop This can be caused by having text with a huge number of spaces.

This causes \n characters to be displayed more consistently.

…empty

Add initial PDFReference specs

Implement encryption and access privileges

Complete coffee -> JS conversion

…relative paths accordingly

…rent runs or systems

…un only integration tests

Improve tests structure Load src files directly allowing to test without build step and test isolated classes Separate tests into two categories: unit and integration Allow to use ES modules in tests Ensure test output is the same across different runs / systems

Remove setTimeout call in PDFReference.finalize

Use property getter to define PDFPage lazy dictionaries

Use sync version of zlib deflate method to compress png images

Fix transparent grayscale png

Fix 16bit png files with alpha channel

Signed-off-by: Ry Jones <ry@linux.com>

DuncanMacWeb · 2019-03-14T19:24:13Z

I am considering if it’s possible to extract the LZW data from the GIF and embed it directly without decompressing the source image data, using the LZWDecode compression type, as explained in this post by Peter Headland...

(possibly using mathatan/gifuct-js)

…/gifuct-js subrepo: subdir: "lib/image/gifuct-js" merged: "961f796" upstream: origin: "https://github.com/mathatan/gifuct-js.git" branch: "master" commit: "961f796" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "5d6aba9"

…arser.git lib/image/js-binary-schema-parser subrepo: subdir: "lib/image/js-binary-schema-parser" merged: "7169e72" upstream: origin: "https://github.com/matt-way/jsBinarySchemaParser.git" branch: "master" commit: "7169e72" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "5d6aba9"

DuncanMacWeb · 2019-03-28T11:02:26Z

@diegomura is there a trick in getting PDFkit to build? What commands do you have to run? I’m running into errors locating base64-ified fonts:

Cannot find module './data/Courier.b64.afm' from 'standard.js' (expand for details)

➜  pdfkit git:(master) yarn test
yarn run v1.15.2
$ jest -i
FAIL  tests/integration/vector.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/text_decorations.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/tables.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/page_references.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/lists.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/watermark.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/columns_simple.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/basics.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/background.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/qrcode.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/absolute.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/toc.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/unit/trailer.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/fonts.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/unit/reference.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/security.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/unit/png.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/text.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/unit/color.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

FAIL  tests/integration/pdfmake/images.spec.js
● Test suite failed to run

    Cannot find module './data/Courier.b64.afm' from 'standard.js'

    2 | import AFMFont from './afm'
    3 | import PDFFont from '../font'
    > 4 | import Courier from './data/Courier.b64.afm'
        | ^
    5 | import CourierBold from './data/Courier-Bold.b64.afm'
    6 | import CourierOblique from './data/Courier-Oblique.b64.afm'
    7 | import Helvetica from './data/Helvetica.b64.afm'

    at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:221:17)
    at Object.<anonymous> (lib/font/standard.js:4:1)

Test Suites: 20 failed, 20 total
Tests:       0 total
Snapshots:   0 total
Time:        10.632s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

theBenForce and others added 30 commits June 22, 2018 17:54

Features/outline (foliojs#831)

f91bdd6

Outline support by @alexvdev and @blforce Close foliojs#216, close foliojs#13

Fix linewrapper ellipsis inifinite loop (foliojs#779)

56c7deb

Long running loop fix (foliojs#796)

7839a41

Fix long-running loop This can be caused by having text with a huge number of spaces.

Fix bug with \n translation (foliojs#797)

93061f3

This causes \n characters to be displayed more consistently.

Allows the text continue feature to work when the starting string is …

2567227

…empty

Fix build config

6e72e0f

Convert to EcmaScript (ES6+) (foliojs#859)

83f5f72

Add initial reference spec

b3c2790

Merge pull request foliojs#883 from blikblum/add-reference-unit-test

6f0d5ff

Add initial PDFReference specs

Add PDF security features with ES6

f5b6ddd

Allow customization of randomizer

2ef9d7d

Add tests for security features and update snapshots

870260c

Downgrade dependency version to avoid fs operation

678148a

Update readme and docs

6398cca

Organize permissions in option to an object

2651a74

Add unit tests for trailer

c400dfa

Merge pull request foliojs#820 from zesik/master

d5d8e3c

Implement encryption and access privileges

Complete coffee -> JS conversion of docs

5274136

Rename docs files, removing the coffee sufix

aec971f

Convert coffeescript code in README.md

e595a8e

Remove coffee-script dependency

3eae185

Merge pull request foliojs#884 from blikblum/cleanup-docs

c09cd64

Complete coffee -> JS conversion

Import test dependencies directly from src through babel-jest. Adapt …

883983a

…relative paths accordingly

Mock PDFSecurity methods in tests to ensure same output accross diffe…

5f125f7

…rent runs or systems

Update saved snapshots

8bf29c5

Move integration tests into a separated directory and add script to r…

a1156fb

…un only integration tests

Use sync version of zlib deflate method to compress png images

6488c53

Add png-benchmark demo

fe8632b

Remove setTimeout call in PDFReference.finalize

4e90b87

blikblum and others added 20 commits December 21, 2018 23:40

Add png unit tests

f2208a7

Merge pull request foliojs#887 from blikblum/remove-reference-timeout

acef5e0

Remove setTimeout call in PDFReference.finalize

Merge pull request foliojs#888 from blikblum/simplify-pdfpage

8f1bb8c

Use property getter to define PDFPage lazy dictionaries

Merge pull request foliojs#889 from blikblum/png-sync

eb60ed1

Use sync version of zlib deflate method to compress png images

Fix defining Mask for grayscale transparent PNG files

faad6e8

Add new png tests

7c6134a

Fix grayscale PNG images with alpha channel

ffdda49

Use a loop to copy png image data instead of Buffer.copy

acbeceb

Merge pull request foliojs#891 from blikblum/fix-grayscale-png

2955161

Fix transparent grayscale png

Fix 16bit png files with alpha channel

b7edc73

Avoid code duplication in copy image data routine

dfb5f93

Merge pull request foliojs#893 from blikblum/fix-16bit-alpha

b83371e

Fix 16bit png files with alpha channel

Remove outdated Gratipay reference (foliojs#896)

ea7927c

Signed-off-by: Ry Jones <ry@linux.com>

Rename src to lib (compatible to fork)

147ebfd

Merge branch 'master' of github.com:foliojs/pdfkit into fork

87bdaef

Apply changes needed for react-pdf

5f42512

Remove deprecated methods from document

b1a15b2

Resolve conflicts with foliojs master

eda7bc5

Add browser check for PDF images

ec35445

Restore page margins constant

49f2c5c

DuncanMacWeb changed the title ~~Add support for GIF images (WIP)~~ Support for GIF images in PDFKit (WIP) Mar 14, 2019

DuncanMacWeb mentioned this pull request Mar 14, 2019

Render GIF images diegomura/react-pdf#531

Closed

DuncanMacWeb force-pushed the gif-support branch from 83489c1 to 58f8e1f Compare March 26, 2019 18:42

Duncan MacKenzie added 2 commits March 27, 2019 11:45

Add support for GIF images

0ef714f

DuncanMacWeb force-pushed the gif-support branch from 58f8e1f to 0ef714f Compare March 27, 2019 12:11

diegomura force-pushed the master branch from 49f2c5c to 205c408 Compare October 27, 2019 03:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support for GIF images in PDFKit (WIP) #7

Support for GIF images in PDFKit (WIP) #7

Uh oh!

DuncanMacWeb commented Mar 14, 2019

Uh oh!

DuncanMacWeb commented Mar 14, 2019 •

edited

Loading

Uh oh!

DuncanMacWeb commented Mar 28, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Support for GIF images in PDFKit (WIP) #7

Are you sure you want to change the base?

Support for GIF images in PDFKit (WIP) #7

Uh oh!

Conversation

DuncanMacWeb commented Mar 14, 2019

Uh oh!

DuncanMacWeb commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DuncanMacWeb commented Mar 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

DuncanMacWeb commented Mar 14, 2019 •

edited

Loading

DuncanMacWeb commented Mar 28, 2019 •

edited

Loading