-
Notifications
You must be signed in to change notification settings - Fork 715
refactor(storage): use new higher rank lifetime assumption to avoid unnecessary clone #23490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a08f8ef to
64c1eb3
Compare
3693fe9 to
5d0b2a0
Compare
|
Looks like this PR extends new SQL syntax or updates existing ones. Make sure that:
|
5d0b2a0 to
aaf3dd0
Compare
cc04230 to
c6bac47
Compare
BugenZhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| echo "--- Build documentation" | ||
| RUSTDOCFLAGS="-Dwarnings" cargo doc --document-private-items --no-deps | ||
| RUSTDOCFLAGS="-Dwarnings -Zhigher-ranked-assumptions" cargo doc --document-private-items --no-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we by default to also set -Dwarnings in config.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good idea. -Dwarnings is used here because we want to quickly detect the warning and return with error in CI, but not a general requirement when we build the doc.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add an experimental rustc flag
"-Zhigher-ranked-assumptions"to bypass the false positive borrow checker error discussed in rust-lang/rust#100013. The rustc flag is recently enabled after rust-lang/rust#143545 gets merged to the rust toolchain.After enabling this rustc flag, for the
on_key_valueandneareststate store trait method, which pass a closure to observe the slice value, the closure does not have to be static, and in the method caller, we can avoid unnecessary clone to make the closure static.Checklist
Documentation
Release note