Skip to content

Dial EC endpoints with a timeout in ExecutionClientManager #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xtrooper wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dial EC endpoints with a timeout in ExecutionClientManager #821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5724ff8
add dialWithTimeout
0xtrooper May 21, 2025
105582e
Fix lint
0xfornax May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions shared/services/ec-manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ func NewExecutionClientManager(cfg *config.RocketPoolConfig) (*ExecutionClientMa
}
}

primaryEc, err := ethclient.Dial(primaryEcUrl)
primaryEc, err := dialWithTimeout(primaryEcUrl)
if err != nil {
return nil, fmt.Errorf("error connecting to primary EC at [%s]: %w", primaryEcUrl, err)
}

var fallbackEc *ethclient.Client
if fallbackEcUrl != "" {
fallbackEc, err = ethclient.Dial(fallbackEcUrl)
fallbackEc, err = dialWithTimeout(fallbackEcUrl)
if err != nil {
return nil, fmt.Errorf("error connecting to fallback EC at [%s]: %w", fallbackEcUrl, err)
}
Expand All @@ -89,6 +89,12 @@ func NewExecutionClientManager(cfg *config.RocketPoolConfig) (*ExecutionClientMa

}

func dialWithTimeout(url string) (*ethclient.Client, error) {
initalConnectionCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
return ethclient.DialContext(initalConnectionCtx, url)
}

/// ========================
/// ContractCaller Functions
/// ========================
Expand Down
Loading