Support server array constructor #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byplayer
commented
Oct 12, 2017
byplayer
commented
- Support server array constructor
- Fix connection error issue when pooling socket is closed by server
- Fix NullPointer exception when call roma function before initialize routingData
If pooled socket expired by ROMA server, socket is closed, but client still has that connection. In that case, client received error. So I checked exception, and catch it, then retry once.
When routing isn't created, then null pointer exception occur
When getConnection is called before initialize routingData, target function throws null pointer exception.
When Pooled connection are closed by server, this method return exception. So add retry logic for it.
Change test ROMA port 11211,11311 to 11311,11411, because 11211 port is unstable on travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.