-
Notifications
You must be signed in to change notification settings - Fork 182
Dynamic message publishers and subscribers #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luca-della-vedova
wants to merge
45
commits into
ros2-rust:main
Choose a base branch
from
luca-della-vedova:dynamic_messages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
2936a40
Add dynamic message functionality
nnmm 9263652
Merge branch 'main' into dynamic_messages
luca-della-vedova aaadbe4
Initial stab, builds docs
luca-della-vedova d5ad50f
WIP work through compile errors
luca-della-vedova d140dbe
Clear warnings
luca-della-vedova f7aa5c0
Bring back tests
luca-della-vedova 236b999
Minor cleanup
luca-della-vedova 780c660
Remove spurious files
luca-della-vedova 4fd4059
WIP working through subscriptions
luca-della-vedova e79f46f
First integration with async workers
luca-della-vedova 73eec6b
Add a PartialEq implementation for tests
luca-della-vedova 76e18d5
Fix test code
luca-della-vedova 5b513ba
Format
luca-della-vedova 8c216af
Minor cleanup
luca-della-vedova 9ab136b
Use SubscriptionOptions
luca-della-vedova a6b5b48
Plumbing for dynamic publishers
luca-della-vedova 8112a77
Add publisher API
luca-della-vedova 73022f7
API symmetry with normal pub/sub
luca-della-vedova 2ccec54
Worker subscriptions
luca-della-vedova 60a542a
Add async subscription API
luca-della-vedova 98381ac
Basic test for dynamic subscriptions graph
luca-della-vedova 164639e
Tests for dynamic pub/sub
luca-della-vedova d1c264a
Worker subscription test
luca-della-vedova 0c11ea0
Minor cleanups and refactors
luca-della-vedova 9ab8dc5
Tests for message field getters / setters
luca-della-vedova 1439045
Minor cleanups
luca-della-vedova 0462d7f
Remove commented code
luca-della-vedova 2b99397
Revert fini change
luca-della-vedova eb5aeeb
Add note on message builder API
luca-della-vedova c4e0bed
Add docs, cleanup tests
luca-della-vedova ccd3852
Fix take logic, cleanup
luca-della-vedova c9a53db
Format
luca-della-vedova 83cf32c
Clear warnings
luca-della-vedova 42cd70f
Cleanup
luca-della-vedova 2f99054
Merge branch 'main' into dynamic_messages
luca-della-vedova 470396b
Add a cache for loaded message packages
luca-della-vedova e21a4a7
Fix panic for empty sequences
luca-della-vedova ba49f22
Merge remote-tracking branch 'origin/main' into dynamic_messages
luca-della-vedova e4ca229
Merge remote-tracking branch 'origin/main' into dynamic_messages
luca-della-vedova 9892e4b
Remove example
luca-della-vedova 8cf5ce0
Merge branch 'main' into dynamic_messages
esteve 4c0fdf8
Update API, remove feature flag
luca-della-vedova 3cd95d4
Remove mentions of dyn_msg in CI
luca-della-vedova 7f38b41
Change to OnceLock
luca-della-vedova 5af0827
Typos
luca-della-vedova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, libloading 0.9 just got released a few weeks ago. Anyway, I think it's fine to keep it on 0.8 and upgrade to 0.9 in a follow-up branch, unless you want to give it a try @luca-della-vedova
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Changelog mentions bumping the MSRV to 1.88, if we want to keep 1.75 compatibility this might be a risky move.