Check tuple type length #2765
Merged
Check tuple type length #2765
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksss
added a commit
to ksss/rbs
that referenced
this pull request
Dec 19, 2025
Check tuple type length
ksss
added a commit
to ksss/rbs
that referenced
this pull request
Dec 19, 2025
Check tuple type length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the tuple type needs to match the values and length of the Array it is being compared to.
Steep performs a length comparison, but rbs/test does not seem to.
By fixing this issue, I was able to discover that the type for
ObjectSpace#reachable_objects_fromwas incorrect.I fixed it to perform a length comparison.