3805 partial cleaning up partner profile #5424
Open
+34
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaning up partner profile
cielf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cleaning up partner profile (removing no-longer-used fields)
Partial solution for #3805
Cleaning up unused fields on partner profile only
From 3805, there was one field not in the db,
There were 3 additional fields that were in the "ignore columns" in profile.db. I have removed them as well. More details on the issue.
Other things you should know about
I didn't do the user fix yet, because a field I expect to be removable has recent data in it -- so there's a need to look further first.
Type of change
How Has This Been Tested?
Light functional testing of partner profile from bank's pov.
Currently having some issues with automated tests on my local, so using the ci here to check that.