split miscellaneous code into a new command_helpers module #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
command_helpers
branch
2 times, most recently
from
8bacfcb to
47d5590
Compare
NobodyXu
requested changes
Jan 29, 2024
Be-ing
force-pushed
the
command_helpers
branch
2 times, most recently
from
3e7ab35 to
0c0bafe
Compare
NobodyXu
requested changes
Jan 29, 2024
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
BTW, it seems that you copied Build into src/build.rs, however there's no mod build; declaration anywhere in the diff.
Be-ing
force-pushed
the
command_helpers
branch
from
0c0bafe to
c2dc883
Compare
Contributor
Author
Be-ing
force-pushed
the
command_helpers
branch
from
c2dc883 to
1af6578
Compare
naoNao89
added a commit
to naoNao89/cc-rs
that referenced
this pull request
Dec 16, 2025
Restore ParentDir check lost in rust-lang#931 refactoring. Paths with '..' now hashed to stay within OUT_DIR. - src/command_helpers: re-add Component::ParentDir check - tests: 3 new regression tests - CHANGELOG: document fix
naoNao89
added a commit
to naoNao89/cc-rs
that referenced
this pull request
Dec 17, 2025
Restore ParentDir check lost in rust-lang#931 refactoring. Paths with '..' now hashed to stay within OUT_DIR. - src/command_helpers: re-add Component::ParentDir check - tests: 3 new regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.