stream sitemap xml to the client #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
stream-sitemap
branch
from
09f4b80 to
96f5274
Compare
GuillaumeGomez
approved these changes
Nov 21, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuilding the dashboards in datadog, this popped to my mind again:
Depending on the letter (I was digging into
/c/), we have 15k or more crates in the list.While the DB query itself could also be optimized (it's around 600ms for that letter),
I think most of the time is spent building the response in memory with askama, then then serving that.
This PR changes the endpoint to stream the result, item by item.
On top of that, I built in error reporting that will alert us if the sitemap gets too big, where would have to split into more sub-sitemaps.