Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Dec 1, 2025

Until now, our rustdoc-json-download handlers just redirected to static.docs.rs, which points to S3 directly.

But with Fastly the invalidation of this service would be tricky and we would have to somehow trick S3 to return surrogate key headers to be able to properly invalidate. There are some workaround, but having the static. subdomain also clashes with the subdomain-per-crate idea.

So I decided to pull this back in. Since then this is now possible because we can stream the body directly from S3 to the client, and don't load the whole body into memory any more.

@syphar syphar self-assigned this Dec 1, 2025
@syphar syphar requested a review from a team as a code owner December 1, 2025 06:15
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 1, 2025
@syphar syphar requested a review from GuillaumeGomez December 1, 2025 10:25
@syphar syphar enabled auto-merge (rebase) December 1, 2025 10:31
@syphar syphar merged commit 1b9214b into rust-lang:main Dec 1, 2025
14 of 15 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 1, 2025
@syphar syphar deleted the direct-json branch December 1, 2025 10:36
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants