directly return rustdoc rustdoc json instead of redirect #3052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, our rustdoc-json-download handlers just redirected to
static.docs.rs, which points to S3 directly.But with Fastly the invalidation of this service would be tricky and we would have to somehow trick S3 to return surrogate key headers to be able to properly invalidate. There are some workaround, but having the
static.subdomain also clashes with the subdomain-per-crate idea.So I decided to pull this back in. Since then this is now possible because we can stream the body directly from S3 to the client, and don't load the whole body into memory any more.