Add unit tests of the different flush kinds #498
Draft
+67
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2025
Member
|
Could we get this done towards the end of the year? Maybe it works now if the PR was rebased? |
fintelia
commented
Dec 9, 2025
Comment on lines
+115
to
+117
|
|
||
| [patch.crates-io] | ||
| miniz_oxide = { git = "https://github.com/Frommi/miniz_oxide", branch = "master" } |
Contributor
Author
There was a problem hiding this comment.
The only thing left should be getting a miniz_oxide 0.8.10 release, so this patch isn't necessary for the tests to pass
Member
|
Right, thanks a lot! I think I may have asked @oyvindln that before and apologise this question is redundant or repetitive, but given my ignorance, is a release of |
Contributor
|
Yeah I'm hoping to get something out before the end of the year, just need to resolve a few small things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests of the various flush kinds to ensure that all backends implement them consistently. The cases are carefully constructed so that even quite different backend implementations are likely to produce the expected output. In particular, it counts on the encoder detecting when the input is/isn't compressible and writing either compressed or stored blocks accordingly.
Tests pass for me with the
zlib,zlib-ng,zlib-rsandcloudflare_zlibbackends. Theminiz_oxidebackend requires Frommi/miniz_oxide#179 as otherwise it treats partial flushes as "no flush" (!)