Skip to content

Rollup of 3 pull requests #150343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 7 commits into from
Dec 24, 2025
Merged

Rollup of 3 pull requests #150343

bors merged 7 commits into from
Dec 24, 2025
+14 −16

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 24, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ChrisDenton and others added 7 commits December 24, 2025 06:41
@ChrisDenton
Avoid using env::temp when linking a binary
b5c473e 
This keeps all build artefacts (even temporary ones) within the build directory.
@ChrisDenton
Rename invalid-tmpdir-env-var
6e35454 
to invalid-tmpdir-no-ice
@heiher
Disable f16 on LoongArch for LLVM < 21
855281c 
The `f16` type works on the LoongArch target starting from LLVM 21.
However, the current minimum supported external LLVM version is 20,
so `f16` must not be enabled on LoongArch for LLVM version < 21.
@bjorn3
Include rustc version in ICE messages
13c6256 
Rather than only including them in the ICE file. Not every user includes
the ICE file in their bug reports, nor do they always list the rustc
version.
@JonathanBrouwer
Rollup merge of rust-lang#150311 - ChrisDenton:no-temp, r=Kivooeo
77fe25a 
Avoid using env::temp when linking a binary

This keeps all build artefacts (even temporary ones) within the build directory.

Fixes rust-lang#139963
@JonathanBrouwer
Rollup merge of rust-lang#150336 - heiher:loong-no-f16-llvm20, r=lqd
2622cc2 
Disable f16 on LoongArch for LLVM < 21

The `f16` type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so `f16` must not be enabled on LoongArch for LLVM version < 21.
@JonathanBrouwer
Rollup merge of rust-lang#150338 - bjorn3:ice_message_version, r=lqd,…
e84aea3 
…hkBst

Include rustc version in ICE messages

Rather than only including them in the ICE file. Not every user includes the ICE file in their bug reports, nor do they always list the rustc version.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 24, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 24, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

📌 Commit e84aea3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025
@bors
Copy link
Collaborator

bors commented Dec 24, 2025

⌛ Testing commit e84aea3 with merge 24ac030...

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 24ac030 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2025
@bors bors merged commit 24ac030 into rust-lang:main Dec 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 24, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 24, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150311 Avoid using env::temp when linking a binary 5bf25aff34e277a4c179aabd418f117698a01ab7 (link)
#150336 Disable f16 on LoongArch for LLVM < 21 a8f06f38754e19ed96581c175809dd6bc1de0c45 (link)
#150338 Include rustc version in ICE messages e8c0a00a7b739fd569eb6bfc28c8f48e122fe486 (link)

previous master: c4aa646f15

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c4aa646 (parent) -> 24ac030 (this PR)

Test differences

Show 8 test diffs

Stage 1

  • [run-make] tests/run-make/invalid-tmpdir-env-var: pass -> [missing] (J0)
  • [run-make] tests/run-make/invalid-tmpdir-no-ice: [missing] -> pass (J0)

Stage 2

  • [run-make] tests/run-make/invalid-tmpdir-env-var: pass -> [missing] (J1)
  • [run-make] tests/run-make/invalid-tmpdir-no-ice: [missing] -> pass (J1)
  • [run-make] tests/run-make/invalid-tmpdir-env-var: ignore (ignored if target does not support std) -> [missing] (J2)
  • [run-make] tests/run-make/invalid-tmpdir-no-ice: [missing] -> ignore (ignored if target does not support std) (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 24ac030a796b9e39bc9d07b6463e633df48e485e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7918.8s -> 5731.6s (-27.6%)
  2. test-various: 6198.3s -> 7030.2s (+13.4%)
  3. aarch64-apple: 9866.6s -> 10764.0s (+9.1%)
  4. x86_64-gnu-llvm-20-2: 5571.2s -> 5089.8s (-8.6%)
  5. aarch64-gnu-llvm-20-1: 3321.3s -> 3592.0s (+8.2%)
  6. armhf-gnu: 5011.6s -> 4603.3s (-8.1%)
  7. pr-check-2: 2305.4s -> 2486.6s (+7.9%)
  8. x86_64-mingw-1: 10124.4s -> 9369.1s (-7.5%)
  9. dist-android: 1525.9s -> 1632.9s (+7.0%)
  10. dist-i686-linux: 5963.6s -> 6375.5s (+6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 24, 2025

Finished benchmarking commit (24ac030): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.8% [-3.8%, -3.8%] 1

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.0%] 36
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.0%] 23
All ❌✅ (primary) -0.1% [-0.1%, -0.0%] 36

Bootstrap: 483.398s -> 483.817s (0.09%)
Artifact size: 392.47 MiB -> 392.35 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer @bors @rust-timer @rustbot @ChrisDenton @heiher @bjorn3