Implement error check for negative edge weights in Graclus #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation to check for negative edge weights in Graclus clustering.
Change to flake8 standards and move to first weight is not None call
Fix flake8 formatting
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 97.32% 97.29% -0.03%
==========================================
Files 11 11
Lines 224 222 -2
==========================================
- Hits 218 216 -2
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative edge weights interfere with Graclus clustering and can cause an indefinite hang when executed on CUDA. This adds a small check to validate the edge weights supplied as input are positive.
An alternative would be to tweak the CUDA implementation to safely handle negative weights, but the effectiveness of the algorithm would still be spotty as negative edge weights can prevent merges and result in many singleton clusters.
#fixes pyg-team/pytorch_geometric#10548