docs(2025): day 06 writeup #896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
force-pushed
the
docs/2025/day06
branch
from
a1b88a5 to
f8467de
Compare
Collaborator
|
let's merge on Tuesday, to give time for review feedback (which I've asked for on Discord) |
merlinorg
approved these changes
Dec 7, 2025
docs/2025/puzzles/day06.md
Outdated
|
|
||
| ```scala | ||
| extension (xs: IterableOnce[(symbol: String, nums: IterableOnce[String])]) | ||
| inline def calculate: Long = xs.iterator.collect { |
Contributor
There was a problem hiding this comment.
inline probably unnecessary
docs/2025/puzzles/day06.md
Outdated
| Let's define an [extension method](https://docs.scala-lang.org/scala3/reference/contextual/extension-methods.html) to improve readability. | ||
|
|
||
| ```scala | ||
| extension (xs: IterableOnce[(symbol: String, nums: IterableOnce[String])]) |
Contributor
There was a problem hiding this comment.
If this takes an xs: Iterator[...] it'll be more apparent how it connects, plus...
docs/2025/puzzles/day06.md
Outdated
| ```scala | ||
| def part2(input: String): Long = | ||
| val lines = input.linesIterator.toVector | ||
| val ops = lines.last.split(raw"\s+").toVector |
Contributor
There was a problem hiding this comment.
This can then be .iterator instead of toVector and then it's just (ops zip xss).calculate which removes the lazyZip complexity. My reasoning being that you chose to make ops a Vector, so the efficiency you speak of is for an inefficiency that is a bit self-imposed.
Just a suggestion to reduce some extraneous things.
else LGTM.
Collaborator
|
@scarf005 can you respond to the review feedback, please? |
scarf005
force-pushed
the
docs/2025/day06
branch
from
76f020e to
7f346a6
Compare
Contributor
Author
|
@SethTisue @merlinorg applied in |
Co-authored-by: merlin <merlin@merlin.org>
scarf005
force-pushed
the
docs/2025/day06
branch
from
7f346a6 to
bcdcdc4
Compare
merlinorg
approved these changes
Dec 9, 2025
Co-authored-by: Merlin Hughes <merlin@merlin.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.