Fix: add Linux and custom font directories #1039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Any plans on merging this someday? 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #469 has been opened for 5 years now and is around 100 commits behind, I've opened this PR including also the suggestion from @szduda to use an environment variable to provide custom font directories in addition to looking at each OS default directories.
I've set the following default directories to look for fonts on Linux:
/usr/share/fonts/usr/local/share/fonts~/.local/share/fonts~/.fontsAll unit tests, acceptance tests (behave) and nosetests (coverage) run OK. Docs have also been updated to warn Linux users that PowerPoint fonts might not be available on their distros, and giving some tips on how to get them.
I believe this might solve the following opened issues: #973 and #796 .