VariableAnalysisSniff::checkForStaticMember(): fix comment tolerance [2] (#148)

PHP ignores comments in unexpected/unconventional places and so should the sniff.

Includes adjusting an existing unit test.

Without the fix, the adjusted unit test would cause test failures.

Author: jrfnl

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -685,8 +685,8 @@ protected function checkForStaticMember(File $phpcsFile, $stackPtr, $varName, $c
     }
     // "When calling static methods, the function call is stronger than the
     // static property operator" so look for a function call.
-    $parenPointer = $phpcsFile->findNext([T_OPEN_PARENTHESIS], $stackPtr, $stackPtr + 2);
-    if ($parenPointer) {
+    $parenPointer = $phpcsFile->findNext(Tokens::$emptyTokens, ($stackPtr + 1), null, true);
+    if ($parenPointer !== false && $tokens[$parenPointer]['code'] === T_OPEN_PARENTHESIS) {
       return false;
     }
     return true;

VariableAnalysis/Tests/CodeAnalysis/fixtures/FunctionWithVariableCallFixture.php

@@ -7,7 +7,7 @@ public function funcUsingSelfCallbackFromAlias($meta, $callback) {
     }
 
     public function funcUsingSelfCallbackFromArgument($meta, $callback) {
-        return self::$callback( $meta  );
+        return self::$callback /*comment*/ ( $meta  );
     }
 
     public function funcUsingStaticCallbackFromArgument($meta, $callback) {