Add Functor and Applicative instances to all Monads #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the minimum required fixes to get greencard building under GHC 7.10. As noted in the comments around the existing Functor instances, though, this may cause compatibility issues with earlier compilers and indeed other, non-GHC Haskell 98 compilers. I am submitting this commit not with a view to having it accepted as is but as a starting-point for a conversation about how to move forward with supporting the latest GHC alongside earlier versions.
Author
|
As noted in the commit message, I've just made the simplest possible changes here to get it to compile under the latest GHC, but these changes can't go in as-is because they will have rather large compatibility implications. The simplest way to resolve these would be to wrap the new instances in CPP guards, hiding them from older versions. I note, though, that the existing Incidentally, what were the compatibility issues that those |
|
+1!! |
|
I ran in to this issue as well. How can I help make this happen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the minimum required fixes to get greencard building under GHC
7.10. As noted in the comments around the existing Functor instances,
though, this may cause compatibility issues with earlier compilers and
indeed other, non-GHC Haskell 98 compilers.
I am submitting this commit not with a view to having it accepted as is
but as a starting-point for a conversation about how to move forward
with supporting the latest GHC alongside earlier versions.