Move GcAllocator into liballoc #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
Move GcAllocator into liballoc
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This removes the dependency for allocation metrics in libstd
jacob-hughes
force-pushed
the
better-api-layer
branch
from
9886a75 to
d94ecee
Compare
Collaborator
Author
|
Force-pushed a fix to |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
Oops. Ive broken the stats generation for allocation with this. Investigating.. |
Collaborator
Author
|
I think I've had to throw my hands up and admit defeat here. See 58b7593 for an explanation. If you're happy, I won't squash it and it can be merged as-is. |
Member
|
Agreed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
These tests check that rustc works with various options that we don't claim to support (e.g. no_rc, no_oom_handling). These are linked with a bare rustc instance and not cargo which fundamentally does not work with the way that we build Alloy. Rather than litter lib/alloc with conditional compilation, I think it's best to disable them for now.
jacob-hughes
force-pushed
the
better-api-layer
branch
from
58b7593 to
d24f676
Compare
Collaborator
Author
|
Force-pushed a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency for allocation metrics in libstd