Prevent unsound allocations in Rc<T> #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I noticed this as an issue while fixing allocation tracking of non-GC objects. Luckily, it seems that the benchmarks that we run do not use this feature, but we should definitely disable it by default. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Currently, there is an unstable API for allocating RC objects with allocators other than the GlobalAllocator. For Alloy this is unsound, as it allows for pointers to GC objects to be missed. This commit provides an error lint which prevents this API from being used. It is enabled by default, but users can disable it with the `#[allow(untracked_heap_allocation)]` attribute.
jacob-hughes
force-pushed
the
untracked-allocation-lint
branch
from
6efab5a to
3410301
Compare
Collaborator
Author
|
The tidy checker requires a working doc test for this lint, so I've force-pushed a fix which adds one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an unstable API for allocating RC objects with allocators other than the GlobalAllocator. For Alloy this is unsound, as it allows for pointers to GC objects to be missed.
This commit provides an error lint which prevents this API from being used. It is enabled by default, but users can disable it with the
#[allow(untracked_heap_allocation)]attribute.