Disable two tests which require filesystem under wasm32-wasip2 #607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an oddity in the ci build logs, where a testsuite failure wasn't causing a ci failure.
I've filed this PR to the
workspace_runnerto fix that, and will give some time for comment period before merging)ratmice/workspace_runner#3
This PR disables the tests that were failing.
One of these tests requires filesystem access to
../../lrpar/exampleswhich isn't going to work with the sandboxWhere the workspace runner allows access to everything between the source directory, and the
$OUT_DIR.But doesn't try to enumerate every path within the workspace.
There is a pre-existing comment that this test should be disabled under wasm32, but it seems like it didn't get disabled.
The other one appears like it should work, as in it seems like it should only require access to the
$OUT_DIRdirectory.So it isn't clear to me exactly why it is failing.