Skip to content

Conversation

@ratmice
Copy link
Collaborator

@ratmice ratmice commented Oct 22, 2025

I noticed an oddity in the ci build logs, where a testsuite failure wasn't causing a ci failure.

I've filed this PR to the workspace_runner to fix that, and will give some time for comment period before merging)

ratmice/workspace_runner#3

This PR disables the tests that were failing.

One of these tests requires filesystem access to ../../lrpar/examples which isn't going to work with the sandbox
Where the workspace runner allows access to everything between the source directory, and the $OUT_DIR.
But doesn't try to enumerate every path within the workspace.

There is a pre-existing comment that this test should be disabled under wasm32, but it seems like it didn't get disabled.

The other one appears like it should work, as in it seems like it should only require access to the $OUT_DIR directory.
So it isn't clear to me exactly why it is failing.

@ltratt
Copy link
Member

ltratt commented Oct 22, 2025

I think we should merge this one as-is. I admit that I'm not sure I understand the workspace_runner link?

@ratmice
Copy link
Collaborator Author

ratmice commented Oct 22, 2025

To explain the workspace_runner link:

https://github.com/softdevteam/grmtools/blob/master/.buildbot.sh#L46C1-L46C31
https://github.com/softdevteam/grmtools/blob/master/.cargo/config.toml#L2

The "workspace_runner" is a binary/test runner for wasmtime,
the executable launches wasmtime but punches some holes in the sandbox, for
cargo environment variables, and paths like OUT_DIR.

But there was a bug in it where it could sometimes fail to reflect the exit status of the wasmtime process.

Edit: I feel I should reiterate that I'm happy to contribute the repo/crate for workspace_runner it to your organization (and continue maintaining it) if that is something you would prefer.

@ltratt
Copy link
Member

ltratt commented Oct 22, 2025

Aha, I'm with you!

It's up to you. FWIW I'm 100% happy with it being on your user account and, indeed, I think arguably you deserve the recognition of it being there.

@ltratt ltratt added this pull request to the merge queue Oct 22, 2025
Merged via the queue into softdevteam:master with commit 93ccab2 Oct 22, 2025
2 checks passed
@ratmice
Copy link
Collaborator Author

ratmice commented Oct 22, 2025

I published a new version of the workspace_runner, will try and remeber to check the logs for the next PR,
but I think the cargo install command in .buildbot.sh should upgrade automatically to the latest version.

Edit: It did successfully install the latest version.

@ratmice ratmice deleted the wasm32_tests branch October 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants