added event notification to segments and rbsegments cache #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
FME-11583-events-split-cache
to
feature/sdk-update-event
December 17, 2025 23:49
sanzmauro
requested changes
Dec 22, 2025
src/Splitio/Services/Cache/Classes/InMemoryRuleBasedSegmentCache.cs
Outdated
Show resolved
Hide resolved
src/Splitio/Services/Cache/Classes/InMemoryRuleBasedSegmentCache.cs
Outdated
Show resolved
Hide resolved
src/Splitio/Services/Cache/Classes/InMemoryRuleBasedSegmentCache.cs
Outdated
Show resolved
Hide resolved
…he.cs Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
…he.cs Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
Co-authored-by: Mauro Sanz <51236193+sanzmauro@users.noreply.github.com>
sanzmauro
requested changes
Dec 23, 2025
Contributor
sanzmauro
left a comment
sanzmauro
left a comment
There was a problem hiding this comment.
I left several comments and suggestions.
Also, please check if we can fix the issues reported by SonarQube. It’s reporting 1 new issue and 10 accepted ones, and from what I reviewed, they should be easy to fix
tests/Splitio-tests/Unit Tests/Cache/InMemory/SegmentCacheTests.cs
Outdated
Show resolved
Hide resolved
tests/Splitio-tests/Unit Tests/Cache/InMemory/SegmentCacheAsyncTests.cs
Outdated
Show resolved
Hide resolved
tests/Splitio-tests/Unit Tests/Cache/InMemory/RuleBasedSegmentCacheTests.cs
Outdated
Show resolved
Hide resolved
sanzmauro
requested changes
Dec 23, 2025
tests/Splitio-tests/Unit Tests/Cache/InMemory/RuleBasedSegmentCacheTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes