Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/*
22
3 changes: 3 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
2.10.1 (December 18, 2025)
- Bugfix - Handle `null` prerequisites properly

2.10.0 (December 16, 2025)
- Added property `impressionsDisabled` in getTreatment(s) `evaluationOptions` parameter, to disable impressions per evaluations.

Expand Down
6,057 changes: 16 additions & 6,041 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@splitsoftware/splitio-commons",
"version": "2.10.0",
"version": "2.10.1",
"description": "Split JavaScript SDK common components",
"main": "cjs/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion src/dtos/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export interface ISplit {
changeNumber: number,
status: 'ACTIVE' | 'ARCHIVED',
conditions: ISplitCondition[],
prerequisites?: {
prerequisites?: null | {
n: string,
ts: string[]
}[]
Expand Down
3 changes: 3 additions & 0 deletions src/evaluator/matchers/__tests__/prerequisites.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ test('MATCHER PREREQUISITES / Edge cases', () => {
const matcherTrueNoPrerequisites = prerequisitesMatcherContext(undefined, mockStorage, loggerMock);
expect(matcherTrueNoPrerequisites({ key: 'a-key' }, evaluateFeature)).toBe(true);

const matcherTruePrerequisitesNull = prerequisitesMatcherContext(null, mockStorage, loggerMock);
expect(matcherTruePrerequisitesNull({ key: 'a-key' }, evaluateFeature)).toBe(true);

const matcherTrueEmptyPrerequisites = prerequisitesMatcherContext([], mockStorage, loggerMock);
expect(matcherTrueEmptyPrerequisites({ key: 'a-key' }, evaluateFeature)).toBe(true);

Expand Down
4 changes: 3 additions & 1 deletion src/evaluator/matchers/prerequisites.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ import { ILogger } from '../../logger/types';
import { thenable } from '../../utils/promise/thenable';
import { IDependencyMatcherValue, ISplitEvaluator } from '../types';

export function prerequisitesMatcherContext(prerequisites: ISplit['prerequisites'] = [], storage: IStorageSync | IStorageAsync, log: ILogger) {
export function prerequisitesMatcherContext(prerequisites: ISplit['prerequisites'], storage: IStorageSync | IStorageAsync, log: ILogger) {

return function prerequisitesMatcher({ key, attributes }: IDependencyMatcherValue, splitEvaluator: ISplitEvaluator): MaybeThenable<boolean> {

prerequisites = prerequisites == null ? [] : prerequisites;

function evaluatePrerequisite(prerequisite: { n: string; ts: string[] }): MaybeThenable<boolean> {
const evaluation = splitEvaluator(log, key, prerequisite.n, attributes, storage);
return thenable(evaluation) ?
Expand Down