feat: add configurable syntax tokens for XML/HTML tags #6130
+59
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds three optional theme tokens for XML/HTML syntax highlighting, allowing custom themes to independently control tag colors instead of inheriting from unrelated tokens. The implementation maintains backward compatibility by providing fallbacks to the original hardcoded color mappings.
- Added
syntaxTag,syntaxAttribute, andsyntaxTagDelimiteras optional theme tokens - Updated type definitions to support the new tokens with proper fallback handling
- Modified the opencode default theme to explicitly define colors for the new tokens
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web/public/theme.json | Added JSON schema definitions for the three new optional syntax token properties |
| packages/opencode/src/cli/cmd/tui/context/theme/opencode.json | Defined explicit color values for the new tokens in the default opencode theme |
| packages/opencode/src/cli/cmd/tui/context/theme.tsx | Updated TypeScript types, resolution logic, and syntax rules to support the new tokens with backward-compatible fallbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add syntaxTag, syntaxAttribute, and syntaxTagDelimiter theme tokens for customizing HTML/XML/JSX tag highlighting. Closes sst#6128
CasualDeveloper
force-pushed
the
feat/syntax-tag-tokens
branch
from
f8fed7d to
3bfd97e
Compare
Author
|
Re-committed with valid GPG signature. Closes #6128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three optional theme tokens for XML/HTML syntax highlighting:
syntaxTag- tag names (fallback:error)syntaxAttribute- attributes (fallback:syntaxKeyword)syntaxTagDelimiter-< > /(fallback:syntaxOperator)Closes #6128