Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 18, 2025

Description

We do not package the mysql provider due to a required dependency. See here. The docs should reflect this.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Dec 18, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Dec 18, 2025
@adwk67 adwk67 enabled auto-merge December 18, 2025 10:34
xeniape
xeniape previously approved these changes Dec 18, 2025
@adwk67 adwk67 added this pull request to the merge queue Dec 18, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Dec 18, 2025
@sbernauer
Copy link
Member

IMHO this is technically wrong (airflow does support mysql, SDP doesn't)
But anyway, generic database connection will make it clear in the CRD what we support

@adwk67 adwk67 removed this pull request from the merge queue due to a manual request Dec 18, 2025
@adwk67
Copy link
Member Author

adwk67 commented Dec 18, 2025

IMHO this is technically wrong (airflow does support mysql, SDP doesn't) But anyway, generic database connection will make it clear in the CRD what we support

I'll change the comment to make it more accurate.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adwk67 adwk67 added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 8607318 Dec 18, 2025
10 checks passed
@adwk67 adwk67 deleted the docs/supported-dbs branch December 18, 2025 11:04
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

6 participants