Skip to content

Conversation

@petar-omni
Copy link
Collaborator

@petar-omni petar-omni commented Nov 17, 2025

  • Base rainbowkit main branch changes

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the latest changes from the base branch, focusing on wallet connector updates and infrastructure improvements. Key changes include wallet rebrands (XDEFI → CTRL, Argent → Ready), new wallet integrations, dependency upgrades, and enhanced testing infrastructure.

Key Changes

  • Wallet Ecosystem Updates: Rebranded XDEFI to CTRL wallet, Argent to Ready wallet, replaced Coinbase Wallet with Base Account in default wallet list
  • New Wallet Integrations: Added Nova, Porto, Gemini, Universal Profiles wallets with proper connector implementations
  • Infrastructure Improvements: Added comprehensive test infrastructure with MSW for WalletConnect mocking, upgraded wagmi to ^2.19 and viem to 2.38.0, improved pnpm workspace configuration

Reviewed Changes

Copilot reviewed 56 out of 68 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Enhanced workspace configuration with package age restrictions
packages/rainbowkit/test/mockWalletConnect.ts New WalletConnect testing utilities with MSW server setup
packages/rainbowkit/test/mockRainbow.ts Rainbow wallet mock utilities for EIP-1193/6963 testing
packages/rainbowkit/src/wallets/walletConnectors/ctrlWallet/ctrlWallet.ts New CTRL wallet connector replacing deprecated XDEFI
packages/rainbowkit/src/wallets/walletConnectors/baseAccount/baseAccount.ts New Base Account connector replacing Coinbase Wallet
packages/rainbowkit/src/wallets/walletConnectors/argentWallet/argentWallet.ts Deprecated Argent, now delegates to Ready wallet
packages/rainbowkit/src/wallets/walletConnectors/[various]/[wallet].ts Fixed mobile visibility by conditionally setting installed property
packages/rainbowkit/src/components/ConnectOptions/DesktopOptions.tsx Renamed WalletStep.None to SelectWallet for clarity
packages/rainbowkit/src/components/ConnectModal/ConnectFlow.test.tsx Comprehensive integration tests for wallet connection flows
packages/rainbowkit/src/wallets/useWalletConnectors.ts Enhanced connect function to support parameters and proper typing
packages/rainbowkit/src/locales/en_US.json Updated localization for renamed/new wallets
package.json Upgraded dependencies (wagmi ^2.19.3, viem 2.38.0, pnpm 10.21.0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@jdomingos jdomingos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no issues I could find

@petar-omni petar-omni merged commit eaf13d7 into main Nov 17, 2025
14 checks passed
@petar-omni petar-omni deleted the feat/base-latest-changes branch November 17, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants