-
-
Notifications
You must be signed in to change notification settings - Fork 18
build: update build sequence to use STDLIB_BRANCH environment variable
#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
STDLIB_BRANCH environment variable when set
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
| # @example | ||
| # make clone-stdlib-version STDLIB_BRANCH=v0.2.0 | ||
| #/ | ||
| clone-stdlib-version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit odd to place this target here, but I also don't immediately have a better idea, so fine to leave as is for now.
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this PR is looking fine. Left a few minor comments.
STDLIB_BRANCH environment variable when setSTDLIB_BRANCH environment variable
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #101
Checklist
tools/scripts/utils/stdlib_version.jsto returnSTDLIB_DOCS_DIRNAMEenv var if setSTDLIB_BRANCHvariable to Makefile (defaults todevelop)STDLIB_DOCS_DIRNAMEfromSTDLIB_BRANCH:develop→latest/with-(e.g.,feature/docs→feature-docs)clone-stdlib-versiontarget that:node_modules/@stdlib/stdlibnode_modules/@stdlib/stdlibdevelopbranch whenSTDLIB_BRANCHis not specifiedmake install-node-modulesin stdlib directoryapi-docstarget to:clone-stdlib-versionSTDLIB_DOCS_DIRNAMEto build scriptsmake api-docsuses develop branch (outputs tolatest/)make api-docs STDLIB_BRANCH=v0.2.0(outputs tov0.2.0/)/(e.g.,feature/docs→feature-docs/)STDLIB_DOCS_DIRNAMEis set correctly for all build scriptsDescription
This pull request implements the first step in #101
So now you can build the docs for v0.3.2 with
make build STDLIB_BRANCH=v0.3.2and the generated docs will end up atpublic/docs/api/v0.3.2.@stdlib-js/reviewers