fix(wg create): break endless loop when file exists #4664
+36
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4665
Change Summary
What and Why:
This fixes endless loop in when supplied
wg createfilename already exists. The problem was caused byargOrPrompthelper, which always returns the command line argument if it is set, so the prompt never appears in this case.How:
Added
flag.GetArg(ctx, idx)helper to clean up the logic. Then reworked the loop so that it first checks for all favorable conditions, and then runs prompt without the helper that attempts to do too much.Now if there is a problem with config file supplied as cmdline argument,
flyctlenters the interactive prompt to allow to fix the mistake.Related to:
#4665
Documentation