Add CI workflows, linting configuration, and code quality improvements #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added GitHub Actions workflows for testing and linting - Added revive linting configuration - Fixed all linter warnings across the codebase - Enhanced README with checksum design documentation - Added comprehensive test for page index checksum validation - Updated .gitignore with Go binary exclusions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This test was already merged in PR #61 and should not be included in this CI/linting PR.
- Replace deprecated math/rand.Read with crypto/rand.Read - Rename min/max variables to minTXID/maxTXID to avoid shadowing built-ins 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Clarify flag field references new flags section - Add details about when WAL fields are zero - Improve salt field descriptions for journal/compacted cases - Clarify node ID field behavior when unset - Add Header flags section documenting LZ4 compression flag 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive CI/CD infrastructure, linting configuration, and various code quality improvements to the LTX project.
Changes Made
CI/CD Infrastructure
test-and-lint.yml: Runs tests across Go 1.22, 1.23, 1.24, executes linters (go fmt, go vet, staticcheck, revive), and builds the projectrace-detection.yml: Prepared for future race condition testing (currently disabled).revive.toml: Comprehensive linting configuration with appropriate rules for the projectCode Quality Improvements
SQLITE_DATABASE_HEADER_STRING→sqliteDatabaseHeaderString)math/rand.Readwithcrypto/rand.Readin testsDocumentation Updates
Build Configuration
.gitignore: Added Go binary exclusions (cmd/ltx/ltx,ltx)File Changes Summary
.revive.tomlconfiguration (56 lines)Test Plan
🤖 Generated with Claude Code