Add a RequestContext to the request handler #26
Conversation
| public protocol HTTPRequestContext: Sendable { | ||
|
|
||
| } | ||
|
|
||
|
|
||
| public struct HTTPServerRequestContext: HTTPRequestContext { |
There was a problem hiding this comment.
Does it need to be a protocol and can we add some docs?
There was a problem hiding this comment.
Oops, forgot to push the docs.
I thought it would make sense so different implementations can add their own stuff to it, like say for NIO it could expose the stream channel or some other implementation specific information.
There was a problem hiding this comment.
Type names could definitely be improved but I was thinking the concrete implementation would be NIO's context.
There was a problem hiding this comment.
I think this should be a concrete type really and then this type might hold a transport specific existential honestly. Introducing another generic parameter isn't going to make it easier :D Also we don't need the transport existential yet we can add it later. This is similar to what gRPC is doing
There was a problem hiding this comment.
Okay yeah that makes sense to match gRPC. I've redone this - what do you think now?
# Conflicts: # Sources/HTTPServer/HTTPServerClosureRequestHandler.swift # Sources/HTTPServer/HTTPServerProtocol.swift # Sources/HTTPServer/HTTPServerRequestHandler.swift
gjcairo
force-pushed
the
request-context
branch
from
2767e7e to
361a624
Compare
No description provided.