Skip to content

Conversation

@cachemeifyoucan
Copy link
Contributor

Default to use new swift-driver to run lit tests as legacy swift driver is deprecated for a long time. The lit tests for legacy drivers are also disable when running new swift-driver.

Tests that relies on legacy swift driver (for example, tests merge module) can be enabled on conditions legacy_swift_driver. Fix and split up some existing tests that relies on legacy driver.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test linux platform

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the fix-new-swift-driver-tests branch from c9b605b to dd5a93d Compare December 10, 2025 20:01
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the fix-new-swift-driver-tests branch from dd5a93d to 9364e16 Compare December 10, 2025 20:22
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't REQUIRES: legacy_swift_driver effectively delete the test? Most platforms would be using the swift driver.

@cachemeifyoucan
Copy link
Contributor Author

Wouldn't REQUIRES: legacy_swift_driver effectively delete the test? Most platforms would be using the swift driver.

Effectively, yes. This serves as a label to see if there are any gaps we need to fill before deleting them.

Windows is still a bit rough because lit tests often has a mix of path separators and new swift-driver actually canonicalize some paths (like sdk path, input paths, etc). This causes some check will be very hard to write, also makes some prefix mapping not possible.

Convert this to a draft since I don't have good idea how to fix yet.

@cachemeifyoucan cachemeifyoucan marked this pull request as draft December 10, 2025 20:41
Default to use new swift-driver to run lit tests as legacy swift driver
is deprecated for a long time. The lit tests for legacy drivers are also
disable when running new swift-driver.

Tests that relies on legacy swift driver (for example, tests merge
module) can be enabled on conditions `legacy_swift_driver`. Fix and
split up some existing tests that relies on legacy driver.
@cachemeifyoucan cachemeifyoucan force-pushed the fix-new-swift-driver-tests branch from 9364e16 to 9fa286b Compare December 10, 2025 22:08
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants