Skip to content

fix(snapshot): [123456789] fix tag error #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellertang merged 2 commits into from
Dec 4, 2025
Merged

fix(snapshot): [123456789] fix tag error #3630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
115de17
fix tag error
hellertang Dec 4, 2025
85785fd
fix tag error
hellertang Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3630.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_cbs_snapshot: fix the issue that cannot setting tags
```
6 changes: 3 additions & 3 deletions tencentcloud/services/cbs/resource_tc_cbs_snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func resourceTencentCloudCbsSnapshotCreate(d *schema.ResourceData, meta interfac
if tags := helper.GetTags(d, "tags"); len(tags) > 0 {
tcClient := meta.(tccommon.ProviderMeta).GetAPIV3Conn()
tagService := svctag.NewTagService(tcClient)
resourceName := tccommon.BuildTagResourceName("cvm", "volume", tcClient.Region, d.Id())
resourceName := tccommon.BuildTagResourceName("cvm", "snapshot", tcClient.Region, d.Id())
if err := tagService.ModifyTags(ctx, resourceName, tags, nil); err != nil {
return err
}
Expand Down Expand Up @@ -238,7 +238,7 @@ func resourceTencentCloudCbsSnapshotRead(d *schema.ResourceData, meta interface{
}

tagService := svctag.NewTagService(tcClient)
tags, err := tagService.DescribeResourceTags(ctx, "cvm", "volume", tcClient.Region, d.Id())
tags, err := tagService.DescribeResourceTags(ctx, "cvm", "snapshot", tcClient.Region, d.Id())
if err != nil {
return err
}
Expand Down Expand Up @@ -279,7 +279,7 @@ func resourceTencentCloudCbsSnapshotUpdate(d *schema.ResourceData, meta interfac
oldValue, newValue := d.GetChange("tags")
replaceTags, deleteTags := svctag.DiffTags(oldValue.(map[string]interface{}), newValue.(map[string]interface{}))
tagService := svctag.NewTagService(tcClient)
resourceName := tccommon.BuildTagResourceName("cvm", "volume", tcClient.Region, d.Id())
resourceName := tccommon.BuildTagResourceName("cvm", "snapshot", tcClient.Region, d.Id())
err := tagService.ModifyTags(ctx, resourceName, replaceTags, deleteTags)
if err != nil {
return err
Expand Down
Loading