Tools: Topology: Add sof-ptl-rt722-4ch-echoref.tplg #10453
Conversation
This patch adds into directory development build of variant of sof-ptl-rt722 with echo reference capture for jack and speaker playback. The purpose is to enable testing of the feature. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a new topology configuration file for the RT722 codec with 4-channel PCH-DMIC and echo reference capture capabilities from both jack and speaker outputs, enabling testing of the echo reference feature on the Panther Lake platform.
Key Changes
- Added new topology target
sof-ptl-rt722-4ch-echorefin the development build configuration - Configured echo reference capture from both jack and speaker playback streams
- Enabled enhanced DMIC capture with TDFB and DRC processing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt722-4ch-echoref.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| SDW_JACK_ECHO_REF=true,SDW_SPK_ECHO_REF=true" |
There was a problem hiding this comment.
The new topology configuration is missing the DEEPBUFFER_FW_DMA_MS and DEEP_BUF_SPK parameters that are present in the similar RT721 configuration above (line 430). Consider whether these parameters should also be included for consistency and proper deep buffer functionality.
| SDW_JACK_ECHO_REF=true,SDW_SPK_ECHO_REF=true" | |
| DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,SDW_JACK_ECHO_REF=true,SDW_SPK_ECHO_REF=true" |
There was a problem hiding this comment.
I kept the build of sof-ptl-rt722 otherwise same as in directory production, it didn't contain speaker deep buffer.
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt722-4ch-echoref.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| SDW_JACK_ECHO_REF=true,SDW_SPK_ECHO_REF=true" |
There was a problem hiding this comment.
It seems there is no SDW_JACK_ECHO_REF in the existing code. And do we really need echo reference of the jack?
2 participants
This patch adds into directory development build of variant of sof-ptl-rt722 with echo reference capture for jack and speaker playback. The purpose is to enable testing of the feature.