IpmiFeaturePkg: Add Support for PcdStandaloneMmEnable #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nate-desimone
commented
May 7, 2025
nate-desimone
commented
- Build Standalone MM IPMI drivers only when Standalone MM is enabled.
- Include the correct SMM/Standalone MM IPMI drivers into FvAdvanced.
- Build Standalone MM IPMI drivers only when Standalone MM is enabled. - Include the correct SMM/Standalone MM IPMI drivers into FvAdvanced. Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
nate-desimone
commented
May 7, 2025
| INF IpmiFeaturePkg/BmcElog/DxeBmcElog.inf | ||
| INF IpmiFeaturePkg/BmcElog/SmmBmcElog.inf | ||
| INF IpmiFeaturePkg/GenericElog/Dxe/GenericElog.inf | ||
| !if gMinPlatformPkgTokenSpaceGuid.PcdStandaloneMmEnable == TRUE |
Member
Author
There was a problem hiding this comment.
One thought I had here... does FvAdvanced get processed by the Standalone MM dispatcher?
If no, then we should remove the standalone MM version of these drivers and board code will have to deal with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.