Platform/Intel/WhitleyOpenBoardPkg: Fix build #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TANDALONE modules The purpose of this change is to fix Platform/Intel/WhitleyOpenBoardPkg platforms, which fail to build with unresolved library classes without it. Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
mikebeaton
requested review from
ChaselChiu,
SaiChaganty and
nate-desimone
as code owners
mikebeaton
force-pushed
the
whitley-fix
branch
from
56c7f62 to
1b8fbd4
Compare
These changes plus the preceding commit fix build of all four WhitleyOpenBoardPkg platforms: CooperCityRvp WilsonCityRvp JunctionCity Aowanda Note: Setting gMinPlatformPkgTokenSpaceGuid.PcdStandaloneMmEnable to TRUE at first looks like another route towards a working build, but that is no longer possible since UefiDevicePathLibStandaloneMm.inf was finally removed in tianocore/edk2@fdd6796. Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
mikebeaton
force-pushed
the
whitley-fix
branch
from
1b8fbd4 to
6362bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the build of all four WhitleyOpenBoardPkg platforms:
CooperCityRvp
WilsonCityRvp
JunctionCity
Aowanda
The IpmiFeaturePkg fix is required as WhitleyOpenBoardPkg platforms fail to build with library class not found errors without it.
The remaining Pcd changes are necessary to resolve other library class not found errors within the build.
Note: Setting gMinPlatformPkgTokenSpaceGuid.PcdStandaloneMmEnable to TRUE at first looks like another route towards a working build, but that is no longer possible since UefiDevicePathLibStandaloneMm.inf was finally removed in tianocore/edk2@fdd6796.