Merge upstream PR: Update liburing's submodule in anticipation of the release #27 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See liburing's aeee6681b14fb6fbd087edd58fcf811077651c16 for details. They moved away from loff_t, and the code as is doesn't compile with liburing's master branch.
25bbcbef3e0a8bfba8044be55d08d5116c51dccd added padding to the sq and cq structures. The iou unit tests all fail once liburing is updated to their main branch, which I tracked down to the commit above. This patch also bumps the liburing submodule, to keep things in sync. Although you have in the past expressed a justified preference to use official releases, a release of liburing is really close and I don't see another way to contribute the patch to add the padding without breaking anything if the submodule doesn't move.
padding is also needed in the io_uring struct. I didn't notice it before because all tests for iou (and glommio) pass just fine without it in debug mode, but it turns out they fail in release mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringbahn#27.