Gracefully handle missing/broken lz4/zstd codecs to improve portability #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements graceful degradation for the optional compression dependencies
lz4andzstandard. Previously, the client would fail to import if these libraries were missing, even if they weren't being used.Key changes:
lz4.blockandzstandardintry-except ImportErrorblocks and track the failures inCODECS_UNAVAILABLEtrino.dbapi/trino.clientto dynamically filter the default encoding list based on which codecs could be loaded, including automatically informing the server if some encodings aren't supported (viaX-Trino-Query-Data-Encodingheader)ValueErrorwith the originalImportErrormessage if a user explicitly requests an encoding that is not available.Closes #584
Non-technical explanation
The Trino Python client no longer crashes on startup if the optional
lz4orzstandardlibraries are not installed. Instead, it automatically disables the compression methods that rely on them. If you explicitly try to use a compression method that isn't installed, the client will raise an error explaining that the required library is missing.Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: