-
Notifications
You must be signed in to change notification settings - Fork 815
Property editor composition rewrite for Umbraco 17 #7685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Property editor composition rewrite for Umbraco 17 #7685
Conversation
…ir architecture, and configuration settings
…ce clarity on architecture and custom implementations
…s on Property Editor settings, configuration, and validation handling for improved clarity and usability
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @Luuk1983. I just had a few comments on the wording in a few places where I though it was a either a little repetitive or vague, but mostly seems to me you and your AI helper have done a really good job here. I don't see any factual issues at all, so just have a few tidying up suggestions.
17/umbraco-cms/customizing/property-editors/composition/property-editor-schema.md
Outdated
Show resolved
Hide resolved
17/umbraco-cms/customizing/property-editors/composition/README.md
Outdated
Show resolved
Hide resolved
17/umbraco-cms/customizing/property-editors/composition/README.md
Outdated
Show resolved
Hide resolved
17/umbraco-cms/customizing/property-editors/composition/property-editor-schema.md
Outdated
Show resolved
Hide resolved
…thub.com/Luuk1983/UmbracoDocs into feature/7603_property_editor_composition
|
@AndyButland, I processed your comments (and fixed the reviewdog warnings). If the changes are OK, could you please approve the PR? :) |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for the updates @Luuk1983 - approving now.
📋 Description
This is a rework of the pages that combined describe the part that make up a Property Editor. It covers an overview page, a page about the Property Editor UI and the Property Editor Schema.
📎 Related Issues (if applicable)
Fixes #7603
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Umbraco 17
Deadline (if relevant)