mklive.sh: Redefining the behavior of option -r <repo>
#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't think this is necessary or useful:
|
Contributor
Author
Reason for modificationIf the original mechanism were followed, I wouldn't be able to select only the repository I want; it would still append the three default repositories. In practice, although I know it will continue to execute, it will try repositories I don't need. If the new mechanism is implemented, I will have the choice. I can choose only the repositories I want, and I can still add my own pre-defined repositories that are useful in the given context. Practical explanationoriginal mechanismUnder the original mechanism, execute the following instructions. run sudo ./mklive.shIt will display the following message: it attempts to access a repository I don't need, although I know it will continue to execute. run sudo ./mklive.sh -r "https://repo-fastly.voidlinux.org/current"It includes the repositories I want, but I don't have the option to manually ignore repositories I don't need. new mechanismUnder my modified mechanism, execute the following command. run sudo ./mklive.shThe mechanism is the same as before; it will attempt to access the three preset repos. run sudo ./mklive.sh -r "https://repo-fastly.voidlinux.org/current"Only using the repo I specified. run sudo ./mklive.sh -r "https://repo-fastly.voidlinux.org/current" -r "https://repo-fi.voidlinux.org/current" -r "https://repo-default.voidlinux.org/current"
show in conclusionUnder the new mechanism, I have the option to choose and control which repositories I want to use. This is why I made this change. By the way, I've already modified a version using this mechanism for my project, and it's been verified that it can generate an ISO and boot up and function normally on my machine.In the future, it is expected that void-mklive will be added to the project using the git-submodule approach. Finally, thank you @classabbyamp for taking the time to review my pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine
-r <repo>will be recorded in XBPS_REPOSITORY.-r <repo>, using default repo. it is defined in lib.sh.-r <repo>, just using-r <repo>.-r <repo>can be added multiple times.Example
Example / 1
Example / 2
sudo ./mklive.sh -r "https://repo-fastly.voidlinux.org/current"Example / 3
Link