Darktable #58255
Open
Darktable #58255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5090122.
Contributor
|
Perfectly fine if they're not needed. My PR for 5.2.1 was kind of confusing: I removed the OpenMP patch since I believe it was patched upstream between 5.2.0 and 5.2.1, and then @sgn chimed in and added a no-intltool patch. What's most important is that 5.4.0 builds fine honestly |
Member
|
I would like to eliminate all usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to revert 5090122 by @al20ov first. The patches did not apply anymore and there was no reference as to how they were made. Please chime in, if they are important, so we can maybe find a more permanent solution.
Testing the changes