chore: streamline k8s job TTLs #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
Nov 21, 2025
outdooracorn
requested changes
Nov 25, 2025
tarrow
requested changes
Dec 8, 2025
| ], | ||
| 'spec' => [ | ||
| 'ttlSecondsAfterFinished' => 0, | ||
| 'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week |
Contributor
There was a problem hiding this comment.
Probably does make sense to keep these around for a while
| ], | ||
| 'spec' => [ | ||
| 'ttlSecondsAfterFinished' => 14 * 24 * 60 * 60, // 2 weeks | ||
| 'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week |
Contributor
There was a problem hiding this comment.
I see no issue moving from 2 weeks to one week here. There is a small chance that this means we'll have all been away and are unable to inspect something here but that's probably the case with any length of time we pick
tarrow
reviewed
Dec 8, 2025
Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I challenge these configs and propose to streamline this to at least 1 week for all current jobs.
Reason: jobs with 0 TTL are almost impossible to inspect
Question: does anyone know the choice for these settings or can see any downsides to a change like this?