Improve CA introspection #30263
Improve CA introspection #30263
Conversation
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| TABLED() {str << popStats.Bytes;} | ||
| TABLED() {str << popStats.Rows;} | ||
| } else { | ||
| TABLED() {str << "N/A";} |
There was a problem hiding this comment.
nit: TABLED_ATTRS({{"colspan,"5"}})? (не знаю, как это сочетается с sortable; может быть и плохо)
There was a problem hiding this comment.
Угу, может быть плохо, надо тестить
|
|
||
| void DefaultMonitoringPage(TStringStream& str) { | ||
| HTML(str) { | ||
| PRE() { |
There was a problem hiding this comment.
Не уверен, что всё целиком нужно заворачивать в <pre>
There was a problem hiding this comment.
У нас в таком стиле много другие страниц внутри YDB сделано, поэтому я оттуда скопировал, но можно обсудить и покрутить, как лучше будет выглядеть
Hor911
force-pushed
the
compute_actor_introspection
branch
from
11cba15 to
95da9e4
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
BackportTo backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.
|
5 participants
#30262