Fix README rendering on PyPI and remove uneeded dependencies #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
While using this wrapper for the first time I noticed that a. its readme was not rendering on PyPI (see for yourself) and b. that it was using some external dependencies when there was no need to:
xml.etree.ElementTreecan be used instead oflxml.etree, and the accelerated implementation will be used if possible since Python 3.3jsonissimplejsonbut integrated to the standard library since Python 2.6, which is deprecated, so there is no need to depend on it externallyhtml.parsercould probably be used instead ofhtml5lib, but because behaviours may differ I actually didn't remove that one