Skip to content

Fix README rendering on PyPI and remove uneeded dependencies #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
althonos wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix README rendering on PyPI and remove uneeded dependencies #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489561e
Fix underline length in `README.rst`
althonos Sep 7, 2019
5400f38
Use standard library instead of some external dependencies
althonos Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Notes
This README might be slightly outdated. You can help by submitting a pull request.

Exception handling
--------------
------------------

The methods of this library might throw client or server errors. An error is
an exception coming from the proven
Expand Down
10 changes: 6 additions & 4 deletions orcid/orcid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
"""Implementation of python-orcid library."""

from bs4 import BeautifulSoup
import requests
import simplejson as json
import json
import sys
from lxml import etree
from xml.etree import ElementTree as etree

import requests
from bs4 import BeautifulSoup

if sys.version_info[0] == 2:
from urllib import urlencode
string_types = basestring,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def run_tests(self):
],
cmdclass={'test': PyTest},
description='A python wrapper over the ORCID API',
install_requires=['html5lib', 'beautifulsoup4', 'requests', 'simplejson', 'lxml'],
install_requires=['html5lib', 'beautifulsoup4', 'requests'],
keywords=['orcid', 'api', 'wrapper'],
license='BSD',
long_description=open('README.rst', 'r').read(),
Expand Down