Skip to content

Add support for (Linux) net device injection. #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elezar merged 7 commits into from
Dec 10, 2025
Merged

Add support for (Linux) net device injection. #269

elezar merged 7 commits into from
Dec 10, 2025

Conversation

@klihub
Copy link
Contributor

@klihub klihub commented Apr 9, 2025 •
edited
Loading

This PR adds support for injecting Linux NetDevices to an OCI Spec. In particular, the PR

  • adds NetDevices to ContainerEdits in the CDI Spec
  • implements network device injection to the OCI Spec
  • bumps the CDI Spec version to 1.1.0
  • updates JSON schema with NetDevices
  • adds CDI Spec version validation to the cmd/cdi test/cli binary
  • updates SPEC.md with info about NetDevices
  • updates SPEC.md with info about recent RDT changes
  • updates JSON schema to reflect recent RDT changes

@klihub klihub force-pushed the devel/linux-net-device branch 3 times, most recently from 658b35b to 9900940 Compare April 9, 2025 13:37
elezar
elezar reviewed Apr 9, 2025
View reviewed changes
elezar
elezar reviewed Apr 9, 2025
View reviewed changes
elezar
elezar reviewed Apr 9, 2025
View reviewed changes
elezar
elezar reviewed Apr 9, 2025
View reviewed changes
elezar
elezar reviewed Apr 9, 2025
View reviewed changes
@klihub klihub force-pushed the devel/linux-net-device branch from 9900940 to e95cee0 Compare April 9, 2025 14:55
@klihub klihub requested a review from elezar April 10, 2025 05:03
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

@elezar elezar added this to the CDI Specification v1.1.0 milestone Aug 7, 2025
@elezar
Copy link
Contributor

elezar commented Aug 7, 2025

@klihub is there a version of the OCI runtime spec that includes these fields now? Could we update this PR so that we can look at pushing out a v1.1.0 of the spec together with the changes from #278 and #279?

@klihub
Copy link
Contributor Author

klihub commented Aug 7, 2025

@klihub is there a version of the OCI runtime spec that includes these fields now?

@elezar Not with a tagged version yet, unfortunately.

Could we update this PR so that we can look at pushing out a v1.1.0 of the spec together with the changes from #278 and #279?

I think we don't need to wait for this to get merged to tag a new version. We can tag a release without this right away, if everything else has been already merged. But we can't merge #279 yet, for the same reason. intelRdt.enableMonitoring is not available yet in a tagged version of the OCI Spec.

@elezar
Copy link
Contributor

elezar commented Nov 5, 2025

It seems as if the v1.3.0 spec has been tagged.

@klihub
Copy link
Contributor Author

klihub commented Nov 7, 2025

It seems as if the v1.3.0 spec has been tagged.

Yes, but I think we'll need for opencontainers/runtime-tools#795 (and opencontainers/runtime-tools#797) to get merged.

@klihub klihub force-pushed the devel/linux-net-device branch 2 times, most recently from 65cfa10 to 55029b7 Compare November 14, 2025 11:27
@klihub klihub marked this pull request as ready for review November 14, 2025 12:09
@klihub klihub requested review from bart0sh and kad November 14, 2025 12:09
@klihub klihub force-pushed the devel/linux-net-device branch from 55029b7 to fa0e7fd Compare November 14, 2025 13:36
@klihub klihub mentioned this pull request Nov 14, 2025
Merged
@bart0sh
Copy link
Contributor

bart0sh commented Nov 17, 2025

@klihub lgtm. Do we need to update/add any tests for the new fields?

bart0sh
bart0sh reviewed Nov 17, 2025
View reviewed changes
@klihub klihub force-pushed the devel/linux-net-device branch from fa0e7fd to 0ea4bfd Compare November 17, 2025 09:14
@klihub
Copy link
Contributor Author

klihub commented Nov 17, 2025

@klihub lgtm. Do we need to update/add any tests for the new fields?

@bart0sh Yes, I think we'd need those and they are missing now. I'll add them.

@klihub klihub force-pushed the devel/linux-net-device branch 4 times, most recently from 142705c to 998d504 Compare November 21, 2025 06:13
@klihub
Copy link
Contributor Author

klihub commented Nov 25, 2025

Ping @elezar, PTAL.

@klihub klihub force-pushed the devel/linux-net-device branch from 998d504 to a46466e Compare November 25, 2025 08:20
elezar
elezar reviewed Nov 25, 2025
View reviewed changes
elezar
elezar reviewed Nov 25, 2025
View reviewed changes
elezar
elezar reviewed Nov 25, 2025
View reviewed changes
@klihub klihub force-pushed the devel/linux-net-device branch 3 times, most recently from 2112626 to 7416131 Compare November 26, 2025 14:34
@klihub klihub requested a review from elezar November 26, 2025 14:35
@klihub
schema: add ContainerEdits.NetDevices.
5e3870c 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
specs-go,cdi: implement NetDevice injection.
c5a3a62 
Implement OCI Spec (Linux) NetDevice injection.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
specs-go: bump version to 1.1.0.
5cefa6b 
Bump current version to 1.1.0, include net devices in minimum
required version check.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
cmd/cdi: validate also Spec version.
b297834 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the devel/linux-net-device branch from 7d96b13 to b297834 Compare November 26, 2025 14:39
elezar
elezar reviewed Nov 26, 2025
View reviewed changes
elezar
elezar reviewed Nov 26, 2025
View reviewed changes
elezar
elezar reviewed Nov 26, 2025
View reviewed changes
elezar
elezar approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klihub this looks good now.

Some minor questions regarding whether this should include edits to SPEC.md, but I am approving this provisionally.

@klihub
SPECS.md: add v1.1.0 with new NetDevices, updates for RDT.
c8531e8 
Update spec description, adding net devices and updating
RDT to reflect recent changes.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
schema: update for recent RDT changes.
18d950c 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
Copy link
Contributor Author

klihub commented Dec 10, 2025 •
edited
Loading

@klihub this looks good now.

Some minor questions regarding whether this should include edits to SPEC.md, but I am approving this provisionally.

@elezar Added 1 extra commits to update SPECS.md for NetDevices and the recent RDT changes, to sync the JSON schema with the recent RDT changes, and to add clarifying 'Added in' comments for the recently added RDT fields.

@klihub
specs-go: add 1.1.0 version-clarification comments for recent RDT fie…
1badadd 
…lds.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
elezar
elezar reviewed Dec 10, 2025
View reviewed changes
specs-go/version.go
}
}

if len(spec.ContainerEdits.NetDevices) != 0 {
Copy link
Contributor

@elezar elezar Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really is a big nit: At other places where we're checking non-empty, we explicilty check > 0 and not != 0. Not going to block on this though.

elezar
elezar approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klihub. This looks good now.

Do you want to wait on a review from @bart0sh or @marquiz before I merge?

@elezar elezar merged commit 922fc93 into cncf-tags:main Dec 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elezar elezar elezar approved these changes

@bart0sh bart0sh bart0sh approved these changes

@kad kad Awaiting requested review from kad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

CDI Specification v1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@klihub @elezar @bart0sh